Skip to content

GH-305 Update GitHub Actions workflow to set build label for release and snapshot #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
CitralFlo wants to merge 12 commits into
base: master
Choose a base branch
from
Open

GH-305 Update GitHub Actions workflow to set build label for release and snapshot #305

CitralFlo wants to merge 12 commits into from
+22 −19

Conversation

@CitralFlo
Copy link
Member

@CitralFlo CitralFlo commented Dec 30, 2025

Example artifact names:
For master branch:
EternalCombat master 15

For feature/combat-rework branch:
EternalCombat feature/combat-rework - Snapshot 16

Where 15 and 16 means runner runs - making versions more distinct - GitHub does not collect and store number of runs on specific branch or pull request

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 30, 2025

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@CitralFlo CitralFlo changed the title Update GitHub Actions workflow to set build label for release and snapshot GH-305 Update GitHub Actions workflow to set build label for release and snapshot Dec 30, 2025
@CitralFlo
Copy link
Member Author

CitralFlo commented Dec 30, 2025

Example from this branch:
image

@Jakubk15
Copy link
Member

Jakubk15 commented Dec 30, 2025

@CitralFlo Can you fix the deprecation warnings?
image

@Jakubk15
Copy link
Member

Jakubk15 commented Dec 30, 2025 •
edited
Loading

I think it would also be cool to introduce a short commit hash.
Not in the GitHub Action zip file itself, but it would help, for example, in the name of a JAR file. We sometimes tend to build experimental snapshot JARs for our community members in tickets to quickly change a function in the plugin, and it would greatly help to identify the JARs instead of just having them named as 2.3.0-SNAPSHOT. The file name could look like this:
EternalCombat 2.3.0-master+cbe468c.jar

@Jakubk15 Jakubk15 removed their request for review January 5, 2026 09:14
@CitralFlo
Copy link
Member Author

CitralFlo commented Jan 7, 2026

Final version:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rollczi Rollczi Rollczi approved these changes

@imDMK imDMK imDMK approved these changes

@noyzys noyzys Awaiting requested review from noyzys

@mydelkonivea mydelkonivea Awaiting requested review from mydelkonivea

@vLuckyyy vLuckyyy Awaiting requested review from vLuckyyy

@igoyek igoyek Awaiting requested review from igoyek

@P1otrulla P1otrulla Awaiting requested review from P1otrulla

@VerniQ VerniQ Awaiting requested review from VerniQ

@Qbiterv Qbiterv Awaiting requested review from Qbiterv

@Pawelusze Pawelusze Awaiting requested review from Pawelusze

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CitralFlo @Jakubk15 @Rollczi @imDMK